[PATCH 1/2] Nuke debian patch disable-git-version.diff.
Thiago Macieira
thiago at macieira.org
Mon May 13 07:36:09 PDT 2013
On segunda-feira, 13 de maio de 2013 09.35.44, Cristian Ionescu-Idbohrn wrote:
> On Sun, 12 May 2013, Thiago Macieira wrote:
> > On domingo, 12 de maio de 2013 23.39.12, Cristian Ionescu-Idbohrn wrote:
> > > Signed-off-by: Cristian Ionescu-Idbohrn
> > > <cristian.ionescu-idbohrn at axis.com>
> >
> > The change looks self-explanatory, but it would be nice if it were
> > actually
> > explained. What's wrong with the current way?
>
> Running:
>
> $ git describe
>
> in a code tree lacking dir .git (unpacked release tar-ball, for
> example) throws an error:
>
> fatal: Not a git repository ...
>
> and that's noise that can be avoided.
Indeed. A summary of that should be written in the commit message.
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Software Architect - Intel Open Source Technology Center
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130513/8d64dc5f/attachment.sig>
More information about the subsurface
mailing list