[PATCH 1/2] Nuke debian patch disable-git-version.diff.

Dirk Hohndel dirk at hohndel.org
Mon May 13 07:38:13 PDT 2013


I will add that. No need to resend the patch.

/D



On May 13, 2013 7:36:09 AM Thiago Macieira <thiago at macieira.org> wrote:
> On segunda-feira, 13 de maio de 2013 09.35.44, Cristian Ionescu-Idbohrn wrote:
> > On Sun, 12 May 2013, Thiago Macieira wrote:
> > > On domingo, 12 de maio de 2013 23.39.12, Cristian Ionescu-Idbohrn wrote:
> > > > Signed-off-by: Cristian Ionescu-Idbohrn
> > > > <cristian.ionescu-idbohrn at axis.com>
> > > > The change looks self-explanatory, but it would be nice if it were
> > > actually
> > > explained. What's wrong with the current way?
> > Running:
> > 	$ git describe
> > in a code tree lacking dir .git (unpacked release tar-ball, for
> > example) throws an error:
> > 	fatal: Not a git repository ...
> > and that's noise that can be avoided.
>
> Indeed. A summary of that should be written in the commit message.
>
> --
> Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
>    Software Architect - Intel Open Source Technology Center
>       PGP/GPG: 0x6EF45358; fingerprint:
>       E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358




More information about the subsurface mailing list