[PATCH] Don't use "qmake-qt4" as qmake

[Linus Torvalds]

On Tue, May 14, 2013 at 10:33 AM, Thiago Macieira <thiago at macieira.org> wrote:
> On terça-feira, 14 de maio de 2013 09.04.51, Linus Torvalds wrote:
>> On Tue, May 14, 2013 at 9:01 AM, Thiago Macieira <thiago at macieira.org>
> wrote:
>> > We need qmake to get QTBINDIR:
>> >         QTBINDIR = $(shell $(QMAKE) -query QT_INSTALL_BINS)
>>
>> Oh, I think you're doing that wrong.
>
> I wrote that code, I'm pretty sure I'm doing it right :-)

Let's quote some random person earlier in this thread:

 "As you can probably tell, this is a mess. It's impossible to create proper
  solutions because we don't know what the distribution will do..."

Oh, wait. That random person was YOU.

So first you say that it's impossible to fix, then when I tell you how
to fix it you say "I'm pretty sure I'm doing it right".

Thiago, stop f*cking around already.

> I prefer my way. Its equivalent to yours

Except for yours not working. Why are you ignoring that part?

> 1) it works on Windows, where pkg-config is usually not installed, but
> qmake.exe will be. Granted, we're using pkg-config for the -I, -D and -L flags
> already, so building on Windows will require some further changes anyway.

Let me rephrase that:
 "Granted, I'm bullshitting and making up bogus reasons"

> 2) moc_location is missing from the Qt5Core.pc file, but I could easily fix
> that. In fact, I started doing that when I was rewriting Subsurface's Makefile,
> but abandoned it in favour of the above solution.

Ok, so Qt5 is buggered, and the traditional way to find the moc binary
is gone. Fix it.

The fact is, the current Qt branch doesn't compile for me at all.
That's current -git as of right now.

At least with the attached patch, I can compile the damn thing. What's
your solution? Because your *current* one isn't working. Really.

              Linus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: application/octet-stream
Size: 1388 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130514/b8575010/attachment.obj>