[PATCH] Add a "sort role" for sorting the dive list

[Dirk Hohndel]

Wait one minute and pull.

It is ALL WORKING. Beautifully.

The problem is that you're not on IRC so you don't see the
interactions... I guess that's a breakdown of process as the mailing
list is no longer enough to stay up to speed on what's happening.

I guess I should send summary emails or something.

But this would have had to be realtime, anyway :-)

/D

On Thu, 2013-05-30 at 05:59 +0900, Linus Torvalds wrote:
> On Thu, May 30, 2013 at 5:50 AM, Linus Torvalds
> <torvalds at linux-foundation.org> wrote:
> >
> > Hmm. Tomaz' code ends up disabling sorting entirely, so now my patch
> > doesn't seem to matter any more. I'm not exactly sure why sorting got
> > disabled, maybe it's a side effect of catching that "header-clicked"
> > event, and thus the default sorting action never happens. Tomaz
> > probably knows. Tomaz?
> 
> Confirmed. Commit c6f84de37c33 ("Adds the code to make the dive list
> behave like tree or list") explicitly disables sorting with
> "setSortingEnabled(false)", but if you remove that, the sorting still
> works.
> 
> However, commit 4019fdaa24eb ("Switch between Tree / list on column -
> click") that takes over the header click *really* disables sorting -
> removing the setSortingEnabled(false) no longer makes any difference.
> 
> So taking over the header click to determine whether to do list or
> tree view also means that apparently now the header click never gets
> to the "do sorting".
> 
> I don't know enough about Qt to know how to pass the header click
> event through, and make it also do the sort thing..
> 
>             Linus