[PATCH] Add a "sort role" for sorting the dive list

Dirk Hohndel dirk at hohndel.org
Wed May 29 14:41:58 PDT 2013


On Thu, 2013-05-30 at 06:19 +0900, Linus Torvalds wrote:
> On Thu, May 30, 2013 at 6:06 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
> >
> > Wait one minute and pull.
> >
> > It is ALL WORKING. Beautifully.
> 
> Well, almost. The sorting works again, but the sorting marker doesn't
> show up. So you don't actually visually see which column things are
> sorted by any more.

Yeah, I noticed that. Tomaz - I assume that's easy to fix?

There's also another thing that is not quite perfect:

You cannot easily select partial trips when displaying trips.

I.e., in trip mode, expand two consecutive trips and try to select the
dives from the middle of one to the middle of the other. This will
select ALL the dives from the second trip. And you can't even ctrl-click
to unselect them. First you need to ctrl-click on the trip header of the
second trip, THEN you can ctrl-click to unselect individual dives.

Of course simply switching to another sort column (like sort by date)
will fix this and make it work quite easily (and the selection stays
intact when you switch back to trip mode), but it's a bit awkward.

/D



More information about the subsurface mailing list