Bug in OSTC3 downloading code

[Fabrice Rossi]

Hi,

I hope it's ok to CC the subsurface ML about this problem which is
clearly in libdivecomputer: it seems that the subsurface ML is better
indexed in search engines, so I thought it would be convenient for other
OSTC3 owners. I apologize for any inconvenience.

So I have a brand new OSTC3 (number #52) running the latest firmware
(0.93). Under the current git version of subsurface and libdivecomputer,
downloading the dive profiles fails with this message:
[7.708] ERROR: Unexpected ready byte. [in hw_ostc3.c:185
(hw_ostc3_transfer)]
[7.708] ERROR: Failed to read the dive. [in hw_ostc3.c:439
(hw_ostc3_device_foreach)]
[7.709] ERROR: Unexpected echo. [in hw_ostc3.c:129 (hw_ostc3_transfer)]
[7.709] ERROR: Failed to send the command. [in hw_ostc3.c:266
(hw_ostc3_device_close)]

This is under linux, by the way.

I've also tried with the universal tool and I get also an error:
fabrice at pcsamos-07:~/tmp$ universal -b "ostc3" -d test.xml /dev/ttyUSB0
DATETIME 2013-05-30T12:23:20Z (1369916600)
VERSION 0.5.0-devel (3c8ea2c33ce2747cf7308450af7d14dac5bb52c9)
Opening the device (Heinrichs Weikamp OSTC 3, /dev/ttyUSB0).
Registering the event handler.
Registering the cancellation handler.
Downloading the dives.
Event: progress 0.00% (0/2162688)
Event: model=0 (0x00000000), firmware=93 (0x0000005d), serial=52
(0x00000034)
Event: progress 0.05% (1024/2162688)
Event: progress 0.09% (2048/2162688)
Event: progress 0.14% (3072/2162688)
Event: progress 0.19% (4096/2162688)
Event: progress 0.24% (5120/2162688)
Event: progress 0.28% (6144/2162688)
Event: progress 0.33% (7168/2162688)
Event: progress 0.38% (8192/2162688)
Event: progress 0.43% (9216/2162688)
Event: progress 0.47% (10240/2162688)
Event: progress 0.52% (11264/2162688)
Event: progress 0.57% (12288/2162688)
Event: progress 0.62% (13312/2162688)
Event: progress 0.66% (14336/2162688)
Event: progress 0.71% (15360/2162688)
Event: progress 0.76% (16384/2162688)
Event: progress 0.80% (17408/2162688)
Event: progress 0.85% (18432/2162688)
Event: progress 0.90% (19456/2162688)
Event: progress 0.95% (20480/2162688)
Event: progress 0.99% (21504/2162688)
Event: progress 1.04% (22528/2162688)
Event: progress 1.09% (23552/2162688)
Event: progress 1.14% (24576/2162688)
Event: progress 1.18% (25600/2162688)
Event: progress 1.23% (26624/2162688)
Event: progress 1.28% (27648/2162688)
Event: progress 1.33% (28672/2162688)
Event: progress 1.37% (29696/2162688)
Event: progress 1.42% (30720/2162688)
Event: progress 1.47% (31744/2162688)
Event: progress 1.52% (32768/2162688)
Event: progress 1.56% (33792/2162688)
Event: progress 1.61% (34816/2162688)
Event: progress 1.66% (35840/2162688)
Event: progress 1.70% (36864/2162688)
Event: progress 1.75% (37888/2162688)
Event: progress 1.80% (38912/2162688)
Event: progress 1.85% (39936/2162688)
Event: progress 1.89% (40960/2162688)
Event: progress 1.94% (41984/2162688)
Event: progress 1.99% (43008/2162688)
Event: progress 2.04% (44032/2162688)
Event: progress 2.08% (45056/2162688)
Event: progress 2.13% (46080/2162688)
Event: progress 2.18% (47104/2162688)
Event: progress 2.23% (48128/2162688)
Event: progress 2.27% (49152/2162688)
Event: progress 2.32% (50176/2162688)
Event: progress 2.37% (51200/2162688)
Event: progress 2.41% (52224/2162688)
Event: progress 2.46% (53248/2162688)
Event: progress 2.51% (54272/2162688)
Event: progress 2.56% (55296/2162688)
Event: progress 2.60% (56320/2162688)
Event: progress 2.65% (57344/2162688)
Event: progress 2.70% (58368/2162688)
Event: progress 2.75% (59392/2162688)
Event: progress 2.79% (60416/2162688)
Event: progress 2.84% (61440/2162688)
Event: progress 2.89% (62464/2162688)
Event: progress 2.94% (63488/2162688)
Event: progress 2.98% (64512/2162688)
Event: progress 3.03% (65536/2162688)
Event: progress 59.89% (65536/109428)
Event: progress 60.83% (66560/109428)
Event: progress 61.76% (67584/109428)
Event: progress 62.70% (68608/109428)
Event: progress 63.63% (69632/109428)
Event: progress 63.81% (69827/109428)
ERROR: Unexpected ready byte. [in hw_ostc3.c:185 (hw_ostc3_transfer)]
ERROR: Failed to read the dive. [in hw_ostc3.c:439
(hw_ostc3_device_foreach)]
universal.c:746: Error downloading the dives.
ERROR: Unexpected echo. [in hw_ostc3.c:129 (hw_ostc3_transfer)]
ERROR: Failed to send the command. [in hw_ostc3.c:266
(hw_ostc3_device_close)]
Result: Protocol error
fabrice at pcsamos-07:~/tmp$ more test.xml
<device>
fabrice at pcsamos-07:~/tmp$

When I received the computer it had on it a test dive and, strangely, I
was able to download this dive with subsurface. I did a few dives since
and when I tried again to download the dives, the above error started to
appear. I'm not one hundred percent sure, but I think it might have
started after my first trimix dive with the computer.

Is there any else I can try to provide more information?

Best,

Fabrice