Bug in OSTC3 downloading code

[Jef Driesen]

On 30-05-13 19:44, Jef Driesen wrote:
> On 30-05-13 14:39, Fabrice Rossi wrote:
>> I hope it's ok to CC the subsurface ML about this problem which is
>> clearly in libdivecomputer: it seems that the subsurface ML is better
>> indexed in search engines, so I thought it would be convenient for other
>> OSTC3 owners. I apologize for any inconvenience.
>>
>> So I have a brand new OSTC3 (number #52) running the latest firmware
>> (0.93). Under the current git version of subsurface and libdivecomputer,
>> downloading the dive profiles fails with this message:
>> [7.708] ERROR: Unexpected ready byte. [in hw_ostc3.c:185
>> (hw_ostc3_transfer)]
>> [7.708] ERROR: Failed to read the dive. [in hw_ostc3.c:439
>> (hw_ostc3_device_foreach)]
>> [7.709] ERROR: Unexpected echo. [in hw_ostc3.c:129 (hw_ostc3_transfer)]
>> [7.709] ERROR: Failed to send the command. [in hw_ostc3.c:266
>> (hw_ostc3_device_close)]
>>
>> [...]
>>
>> When I received the computer it had on it a test dive and, strangely, I
>> was able to download this dive with subsurface. I did a few dives since
>> and when I tried again to download the dives, the above error started to
>> appear. I'm not one hundred percent sure, but I think it might have
>> started after my first trimix dive with the computer.
>>
>> Is there any else I can try to provide more information?
>
> This is a known issue. Firmware v0.93 introduced a small change in the data
> format. I already have a patch available, and I just need to test it on v0.93
> dives. I recorded the necessary data for that yesterday evening. So unless I run
> out of time, the patch will likely be applied today.

Patch has been applied to the release-0.4 branch. Let me know whether this patch 
works for you or not.

Jef