[PATCH] Fill up plot_data with temperature all the way

Dirk Hohndel dirk at hohndel.org
Wed Nov 13 05:43:20 UTC 2013


On Wed, 2013-11-13 at 14:03 +0100, Anton Lundin wrote:
> > My problem with this patch is that it does the wrong thing for
> > situations where you have only a very small number of temperature
> > readings (e.g.; ONE). I know that I have seen XML files that have a
> > single reading about half way through the dive (at the deepest spot,
> > IIRC). So for dive computers like this it does something rather odd -
> > you get no temperature for most of the dive, and then you get a
> > potentially wrong temperature for the rest of the dive.
> > 
> 
> This patch doesn't change what we store as dc data, its the same as
> before. This just fills up with temperature data in the plot_data, aka
> whats shown, and not whats stored.
> 
> Take a look at dives/test27.xml, it only has a temp sample in the
> beginning and it gets drawn as a straight line for the whole dive. This
> makes that temperature visible in the info box.

See my later response. Linus explained this to me :-)
And I pushed your patch...

/D



More information about the subsurface mailing list