[PATCH] Preferences: Add some units and limits to the GF's

[Dirk Hohndel]

I take it back. I'm not taking this patch as is.

Reading up on it some more there apparently are some crazy divers who
use much higher values than 100. For example look at the discussion at
http://www.rebreatherworld.com/decompression-and-gas-choices/2542-choosing-gradient-factors.html

10/250 seems like a REALLY bad idea, but that's a different issue.
I have emails from Jan (I still miss having him around) where he
discussed friends of his who plan their dives with GF 80/105

And everywhere I look, the GF is represented without '%'.

So I would consider a patch that did '0' as lower limit and changes the
color of the number to red once it is > 100 - but still allows the
number to go up to at least 150

/D

On Sat, 2013-11-16 at 08:09 -0800, Dirk Hohndel wrote:
> I took the patch, but I wonder about the '%' unit... I usually see
> gradient factors just given as 30/70 or something like this, not as
> 30%/70%
> 
> What do others think?
> 
> /D
> 
> On Sat, 2013-11-16 at 11:51 +0100, Anton Lundin wrote:
> > Sets the limit for GF's in the preferences panel to 1<=x<=100 and add a
> > % as unit.
> > 
> > Signed-off-by: Anton Lundin <glance at acc.umu.se>
> > ---
> >  qt-ui/preferences.ui | 24 ++++++++++++++++++++++--
> >  1 file changed, 22 insertions(+), 2 deletions(-)
> > 
> > diff --git a/qt-ui/preferences.ui b/qt-ui/preferences.ui
> > index 7e071fa..444577d 100644
> > --- a/qt-ui/preferences.ui
> > +++ b/qt-ui/preferences.ui
> > @@ -751,7 +751,17 @@
> >               </widget>
> >              </item>
> >              <item row="0" column="1">
> > -             <widget class="QSpinBox" name="gflow"/>
> > +             <widget class="QSpinBox" name="gflow">
> > +              <property name="suffix">
> > +               <string>%</string>
> > +              </property>
> > +              <property name="minimum">
> > +               <number>1</number>
> > +              </property>
> > +              <property name="maximum">
> > +               <number>100</number>
> > +              </property>
> > +             </widget>
> >              </item>
> >              <item row="1" column="0">
> >               <widget class="QLabel" name="label_20">
> > @@ -761,7 +771,17 @@
> >               </widget>
> >              </item>
> >              <item row="1" column="1">
> > -             <widget class="QSpinBox" name="gfhigh"/>
> > +             <widget class="QSpinBox" name="gfhigh">
> > +              <property name="suffix">
> > +               <string>%</string>
> > +              </property>
> > +              <property name="minimum">
> > +               <number>1</number>
> > +              </property>
> > +              <property name="maximum">
> > +               <number>100</number>
> > +              </property>
> > +             </widget>
> >              </item>
> >             </layout>
> >            </widget>
> 
> 
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface