Discrepancies between DC and subsurface's deco

[Dirk Hohndel]

On Fri, 2013-11-22 at 04:28 +0100, Patrick Valsecchi wrote:
> Hi,
> 
> I have a feeling that I hit a nerve or something with this email? If
> it's the case, I'm deeply sorry.

What? Who? When?

> At least have a look at the first patch that just simplifies the code.
> I don't mind if the second one is silently ignored.

Err... have you checked master lately? How about commits fe2eabf3756c
and 4c4a7a6d968f? Do they look familiar?

> Thanks.

No, thank you for your contribution. Since you were making pretty
drastic changes to a IMHO rather fragile part of our code I was waiting
for an ACK from the Qt expert - and he confirmed that your changes are
likely to make that code less fragile. Which is why I took them.

Sorry this took longer than you expected

But actually...

commit fe2eabf3756c9883ee8e8c145e5cd12d8d336933
Author:     Patrick Valsecchi <patrick at thus.ch>
AuthorDate: Wed Nov 20 16:11:22 2013 +0100
Commit:     Dirk Hohndel <dirk at hohndel.org>
CommitDate: Thu Nov 21 08:11:40 2013 -0800

    Added a configuration option to have gf_low apply at max depth
instead of at deepest ceiling.
    
    Signed-off-by: Patrick Valsecchi <patrick at thus.ch>
    Signed-off-by: Dirk Hohndel <dirk at hohndel.org>

commit 4c4a7a6d968fa27de72f1510c55d327a7e919d7c
Author:     Patrick Valsecchi <patrick at thus.ch>
AuthorDate: Wed Nov 20 13:40:14 2013 +0100
Commit:     Dirk Hohndel <dirk at hohndel.org>
CommitDate: Thu Nov 21 08:11:40 2013 -0800

    Refactoring of the configuration handling.
    
    Before, when clicking the OK button on the preferences GUI, we were
    updating in-memory preferences from the GUI, saving them to the
    configuration file from the GUI, reloading from the file to the
    in-memory preferences. Then, to add to the ducplication, when the
    application was exiting, some fields were saved again.
    Basically the first step and the last step were useless appart from
    the fact the the other steps where missing a few fields here and
there.
    
    This patch removes the first step and fixes the missing fields.
    
    Signed-off-by: Patrick Valsecchi <patrick at thus.ch>
    ACKed-by: Tomaz Canabrava <tcanabrava at kde.org>
    Signed-off-by: Dirk Hohndel <dirk at hohndel.org>


That's 16h and 18.5h. I'm not quite sure what you were expecting.

/D