[PATCH] Ignore events for gaz change if there is no change.

[Patrick Valsecchi]

Hi,

On 22. 11. 13 19:30, Dirk Hohndel wrote:
> In which language is gas spelled 'gaz'?

French, Crimean Tatar, Polish, Romanian and Turkish.
;-)

> But besides that... I don't think this is correct. We don't correctly
> handle that because of architecture limitations (and we just in the last
> few days had suggestions how to fix that), but it's entirely possible
> that someone might have two tanks with the same gas (even air) and wants
> to switch between them. So simply hiding those events isn't really a
> great idea.

Didn't think some people wanted to track more than one cylinder with the 
same gaz.
Then we could ignore events where entry->cylinderindex doesn't change.

> The 30sec vs. merged dive comment is correct.
>
> The other comment I don't quite understand. The gas change event has a
> time associated with it. That can be right at a sample, or between two
> samples. We should be using the time of the event to track the change in
> gas - but then if you want to be that artificially precise, we don't
> know the actual depth at that time. Fact is that all of our computations
> are approximations based on coarse data. This one item isn't really
> going to make any real difference, given the coarseness of all the other
> data.

I didn't make myself clear. What I don't like is line 936. It is now:
   if (ev->time.seconds < entry->sec)

To me, it's weird that it is not:
   if (ev->time.seconds <= entry->sec)

Then if you do that, it's even weirder, since it looks like the 
plot_data has the wrong cylinder at the exact time of the event. Just an 
off by one error, I guess.

CU
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20131124/5542383a/attachment.html>