Uninitialized values and memory leaks

Patrick Valsecchi patrick at thus.ch
Wed Oct 2 23:33:26 UTC 2013


Hi

On 10/02/2013 05:33 PM, Dirk Hohndel wrote:
> On Wed, 2013-10-02 at 17:09 +0300, Lubomir I. Ivanov wrote:
>> thanks for the patches,
>> perhaps tomaz will have to take a look at this one, as 95% of the code
>> you have modified is written by him.
>> removing application lifetime leaks is not that important, but doing
>> that can indeed reduce the SNR in memory debuggers, unless such
>> already support filtering of some kind...
> Hehe - should have read your response, first.
> Basically "what he said" :-)

You want me to remove the one time leak fixes? Or you are willing to 
consider the whole patch?

>
>>> I've left one leak with a FIXME comment. This one is a bit tough. It would
>>> be way easier if the dive structures were using QString instead of char*.
>>> What is the plan with the GTK UI? If it is going to be dropped, I suggest to
>>> switch to QString, QList and QMap instead all all those C types.
>>>
>> the application "backend" and some C++ portions that link to it will
>> preferably remain in plain C.
> YES.
Weird, but I kind of understand.  ;-)

CU


More information about the subsurface mailing list