[PATCH 2/2] Make the classes generated by uic be real members of our classes

Lubomir I. Ivanov neolit123 at gmail.com
Thu Oct 3 12:32:52 UTC 2013


On 3 October 2013 21:54, Thiago Macieira <thiago at macieira.org> wrote:
> This means we don't have to new/delete them, which is a waste of
> overhead.
>

very nice,
and i think think this might be the way to go in terms of clarity and
since mem. debuggers will no longer report the UI allocations for the
app. runtime on the heap.

but the compilation time increase is quite curios...
i'm running a VM (ehem...i'm looking at you mr. marble-widget-win32),
so the rough measurement for the entire file stack go as:
~ 01:40 minutes without the patches
~ 02:00 minutes with the patches

with gcc 4.6.3

+1 for both patches from me.

so we are now basically helping memory debuggers and not managing the
UI memory our self by making the UI's class members, which might be  a
better practice, but the lack of forward declarations in headers does
not really help the C++ compiler as we are dropping the compile time
by ~20%. :(

lubomir
--


More information about the subsurface mailing list