[PATCH 2/2] Make the classes generated by uic be real members of our classes

[Tomaz Canabrava]

broke for me ( I did a make confclean before trying to make. )

    UIC qt-ui/mainwindow.ui
    CXX main.cpp
In file included from qt-ui/ui_mainwindow.h:26:0,
                 from qt-ui/mainwindow.h:13,
                 from main.cpp:12:
qt-ui/diveplanner.h:11:28: fatal error: ui_diveplanner.h: No such file or
directory
 #include "ui_diveplanner.h"
                            ^
compilation terminated.
make: *** [main.o] Error 1



On Thu, Oct 3, 2013 at 4:32 PM, Lubomir I. Ivanov <neolit123 at gmail.com>wrote:

> On 3 October 2013 21:54, Thiago Macieira <thiago at macieira.org> wrote:
> > This means we don't have to new/delete them, which is a waste of
> > overhead.
> >
>
> very nice,
> and i think think this might be the way to go in terms of clarity and
> since mem. debuggers will no longer report the UI allocations for the
> app. runtime on the heap.
>
> but the compilation time increase is quite curios...
> i'm running a VM (ehem...i'm looking at you mr. marble-widget-win32),
> so the rough measurement for the entire file stack go as:
> ~ 01:40 minutes without the patches
> ~ 02:00 minutes with the patches
>
> with gcc 4.6.3
>
> +1 for both patches from me.
>
> so we are now basically helping memory debuggers and not managing the
> UI memory our self by making the UI's class members, which might be  a
> better practice, but the lack of forward declarations in headers does
> not really help the C++ compiler as we are dropping the compile time
> by ~20%. :(
>
> lubomir
> --
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20131003/be049bda/attachment.html>