Uninitialized values and memory leaks

[Patrick Valsecchi]

Dirk,

I've submitted 3 other patches to the mailing list. It's normal you are 
starting to see failed chunks if they are not applyied in the correct 
order and I see that with the modifications on master, they don't apply 
any more (I'll fix them).

I'll see what happens with the other patches and I'll consider reworking 
this one. I've seen that Lubomir fixed all the ui leaks in another 
patch. I don't really care if there are leaks and the non-initialized 
values are not in an area I plan to use or just work by mistake, so it's 
not on top of my list. Plus, my "happy hacking" days at work are at the 
end.

CU

On 10/03/2013 08:24 PM, Dirk Hohndel wrote:
> Patrick,
>
> I took some more time looking at this. It doesn't apply to master
> (that's because it fixes things from a different patch of yours, I
> think). And it touches too many pieces at once for my liking.
>
> I'd rather see smaller patches that are easy to look at individually and
> to review. Clearly several of the things that you are fixing are obvious
> bugs. Others I'm not so sure about.
>
> I could take the ones that are obvious (to me) and drop the others...
> and then ask you to submit them individually. Would that make sense?
>
> Thanks
>
> /D
>
> On Wed, 2013-10-02 at 15:41 +0200, Patrick Valsecchi wrote:
>> Hi,
>>
>> I ran subsurface with valgrind and it found a few errors. The leaks
>> are mainly a one time thing, but I needed to fix them to reduce the
>> noise and find the real bad leaks.
>>
>> I've left one leak with a FIXME comment. This one is a bit tough. It
>> would be way easier if the dive structures were using QString instead of
>> char*. What is the plan with the GTK UI? If it is going to be dropped, I
>> suggest to switch to QString, QList and QMap instead all all those C types.
>>
>> Please have a look at the patch in attachment (bigger than my previous
>> ones).
>>
>> I think my next "mission" is to figure out why there is only the graph
>> in the printouts when the screenshot [1] shows some text and a table
>> with some data below them. Unless it's a known problem and somebody
>> already works on that?
>>
>> CU
>>
>> [1]
>> http://subsurface.hohndel.org/wp-content/uploads/2011/10/Screen-shot-2013-02-24-at-12.33.59-PM.png
>>
>> _______________________________________________
>> subsurface mailing list
>> subsurface at hohndel.org
>> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>
>