Another compile error

[Thiago Macieira]

On sábado, 5 de outubro de 2013 21:28:36, Sergey Starosek wrote:
> Thiago,
> 
> The actual error is missing there...
> 
> > But the error is happening inside the C++ <string> include.
> 
> See full output attached. I'll try to bisect the problem.

Thank you, I can see what the problem is.

In libdivecomputer.h:

#ifdef __cplusplus
extern "C" {
#endif

[...]
/* handling uemis Zurich SDA files */
#include "uemis.h"


Then uemis.h → dive.h → libxml.h → ICU headers.

We should avoid including other headers under extern "C" unless said header is 
actually missing its own extern "C".

Patch coming.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20131005/0805f074/attachment.sig>