[PATCH] Don't include headers under extern "C" unless we have to.

Cristian Ionescu-Idbohrn cristian.ionescu-idbohrn at axis.com
Sat Oct 5 14:56:54 UTC 2013


On Sat, 5 Oct 2013, Thiago Macieira wrote:
>
> libxml headers include ICU headers and ICU has C++ code. If it detects
> __cplusplus, it will start declaring C++ templates and whatnot, which
> aren't allowed under extern "C".
>
> Signed-off-by: Thiago Macieira <thiago at macieira.org>
> ---
>  Rules.mk          | 8 ++++++--
>  libdivecomputer.h | 8 ++++----
>  uemis.h           | 8 ++++++++
>  3 files changed, 18 insertions(+), 6 deletions(-)

This still doesn't help.  I'm hit by:

g++ -Wall -g     -c -o qthelper.o qthelper.cpp
In file included from qthelper.cpp:1:0:
qthelper.h:4:21: fatal error: QMultiMap: No such file or directory
 #include <QMultiMap>
                     ^
compilation terminated.

See Lubomir's and my patches send to the list.


Cheers,

-- 
Cristian


More information about the subsurface mailing list