[PATCH 4/5] subsurface-configure.pri: add a libiconv dependency

[Lubomir I. Ivanov]

On 9 October 2013 22:54, Thiago Macieira <thiago at macieira.org> wrote:
> On quarta-feira, 9 de outubro de 2013 22:46:09, Lubomir I. Ivanov wrote:
>> On 9 October 2013 22:38, Thiago Macieira <thiago at macieira.org> wrote:
>> > On quarta-feira, 9 de outubro de 2013 21:35:51, Lubomir I. Ivanov wrote:
>> >> From: "Lubomir I. Ivanov" <neolit123 at gmail.com>
>> >>
>> >> This is a bit crude of a solution, but the Win32 version
>> >> of libxslt (or at least some versions) seem to require libiconv,
>> >> thus we add the library with pkg-config if it is available.
>>
>> looks like the version of libxml that i've download is built using iconv
>> LIBXML_ICONV_ENABLED
>>
>> without this patch i get a:
>> /dev/linux_lib/libxml/include/libxml/encoding.h:28:19: fatal error: iconv.h:
>> No such file or directory
>>  #include <iconv.h>
>>
>> we cannot really guarantee what version of libxml-dev users will
>> download for win32, so this is more of a safe guard.
>> if this change does not go in i guess i will try rebuilding libxml.
>
> And iconv.h isn't found in the standard include path, plus what we get from
> xml2-config --cflags?
>

there is no such thing as xml2-config in the dev package that i've
downloaded (same for xslt-config).

> <iconv.h> should really be installed in the standard search dirs.
>

none of my mingw toolchains seem to have it...

> Did you get xml2-config working? Or is your build running without detection?
>

solved that by adding the .pri change to try to obtain the --cflags,
--libs with pkg-config directly.
-> another patch in the same series.

lubomir
--