[PATCH 2/5] subsurface-configure.pri: enable the libusb detection stage

Thiago Macieira thiago at macieira.org
Wed Oct 9 16:06:58 UTC 2013


On quarta-feira, 9 de outubro de 2013 15:00:34, Dirk Hohndel wrote:
> On Thu, 2013-10-10 at 00:54 +0300, Lubomir I. Ivanov wrote:
> > On 10 October 2013 00:26, Thiago Macieira <thiago at macieira.org> wrote:
> > > On quarta-feira, 9 de outubro de 2013 23:30:00, Lubomir I. Ivanov wrote:
> > >> but if tell libdc to *use* libusb and then i produce a
> > >> libdivecomputer.a should libusb be part of that archive?
> > >> my guess is no...
> > > 
> > > No.
> > > 
> > > When static linking to a given library, we have to link to its
> > > dependencies
> > > directly.
> > > 
> > > But I see the problem. Go ahead with your original patch, but remove the
> > > lines that link to libusb that were added in
> > > cfbbf1bffec5e917aa4987f33825f324e2f03976.
> > 
> > ok, i see.
> > it works if i do a: git revert cfbbf1bffec
> 
> Hmm - as discussed many times - I /prefer/ to link statically against
> libdivecomputer. But if that causes us too much grief on Windows, then
> so be it.

Don't do a full revert. Just remove the lines that add libusb-1.0 there.

This patch (#2) is adding libusb-1.0 below for all cases, including those for 
which the library is found in /usr/local.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20131009/bcbbc680/attachment.sig>


More information about the subsurface mailing list