Problems with dive planning module.

[Robert Helling]

On 17.10.2013, at 11:18, Willem Ferguson <willemferguson at zoology.up.ac.za> wrote:

Hi,

> 3) Several dive plans in dive list: When a dive plan is saved, it gets listed in the dive list, together with all one's other real-world logged dives. Now, if one creates the same dive plan more than twice, the dive plan actually looks and behaves very differently. You do not get the same dive plan. An example:
> I created three instances of the dive plan shown at: https://www.dropbox.com/s/ve0ms1550aaa1bj/DivePlan1.png
> Here they are shown in the dive list: https://www.dropbox.com/s/p7xwu9gq4db10xl/DiveList1.png
> Here are the three profiles resulting from this plan: https://www.dropbox.com/s/2w2bhnyd4df1qis/DiveProfiles1.jpg
> I suspect that, perhaps, dive no. 3 is considered a repetitive dive after dive no. 2 in the dive list, i.e. the dive planner sees the other dive plans listed in the dive list????


It is indeed the case that the dives are considered to be repetitive. This is supposed to be a feature to plan repetitive diving.

Here is a patch

-------------- next part --------------
A non-text attachment was scrubbed...
Name: doubleplan.patch
Type: application/octet-stream
Size: 586 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20131017/74a6e524/attachment.obj>
-------------- next part --------------

that changes that behavior such that dives that end later than the start of the current dive (in particular other planned dives starting at the same time) are not used in the repetitive diving calculation.

So you can plan the same dive with different parameters and the different versions do not influence each other. If you are planning a dive that starts after all of them end, _all_ are considered as previous dives for the last one. One might consider this a bug but OTOH which of the dives should be taken into account if there are several?

Signed-off-by: Robert C. Helling

Best
Robert



-- 
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
                      http://www.atdotde.de

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F




-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20131017/74a6e524/attachment.sig>