[PATCH] Set in_deco flags for subsurface calculated deco

Anton Lundin glance at acc.umu.se
Thu Oct 17 14:31:08 UTC 2013


On 14 October, 2013 - Dirk Hohndel wrote:

> 
> On Mon, 2013-10-14 at 22:44 +0200, Anton Lundin wrote:
> > Now when we look at in_deco for ploting of deco-stops, we need to set
> > that flag for non-dc calculated deco too.
> 
> Careful. We want to be able to tell apart whether your dive computer
> thought you were in deco or whether Subsurface thinks that you are in
> deco. These are visualized differently. And IIRC in_deco should only be
> set if the dive computer told us that was its state at that time...
> 

I managed to reply directly to Dirk so we had some discussion off-list.
After that discussion i thought up some alternatives:

1. Add a second set of parameters into the plot_data for the
subsurface-calculated ndl/tts/deco and plot that besides the
dive-computer reported data.

2. Only calculate ndl/tts/deco for dc's that is missing those values and
add a flag for the plot that the ndl/tts/deco is calculated by
subsurface.


1 is interesting to be able to compare our deco code on the same data as
some divecomputers calculations, but how are we going to fit it all into
the plot?


2 is more how i thought when i wrote the code, because i have a Suunto
Vyper that can't do proper deco calculations, and it is interesting to
see the data.


I didn't find any assumptions in the code that would break if the
subsurface-based calculations set the in_deco flag, but i also managed
to miss the ruler functionality up until some days ago =)


//Anton


-- 
Anton Lundin	+46702-161604


More information about the subsurface mailing list