[PATCH v2] Improved handling of latitude and longitude.

Dirk Hohndel dirk at hohndel.org
Tue Sep 17 14:18:16 UTC 2013

Linus just pointed one more thing out that it took a lot of tinkering to
get right in the Gtk version:

The coordinates field needs to have a flag associated with it that
tracks whether the coordinates were hand edited or autocompleted.

Think about this scenario:

user enters Location: Paris and edits the coordinates.
next he goes back and types a previous location name ("Shark Condos,
Lanaii, HI"). The coordinates SHOULD NOT change, as they were explicitly
Now if the user clears the coordinates and once again goes back to the
location and picks "Shark Condos, Lanaii, HI" for the location, THEN the
coordinates should be autofilled.
If the user then picks a different location "Wreck Treck, West Palm
Beach, FL", the coordinates should update as well, as the last
coordinates weren't hand entered buy came from an autocompletion.

Makes sense?


On Tue, 2013-09-17 at 17:10 -0400, Dirk Hohndel wrote:
> Cool, that's one thing that still needed work.
> First test:
> Edit the Coordinates, then click undo. Coordinates are replaced with the
> Location name. Oops. Navigating to different dive and back fixes things
> (so no harm is done), but that's... suboptimal.
> Second test:
> Type in a location on a new dive. Autocomplete works. And the correct
> coordinates are pulled in. 
> YAY!!!
> I'll push as is and trust that you will address the little issue exposed
> in my first test.
> Thank you. And we are VERY interested in this (and similar) enhancement!
> /D
> On Tue, 2013-09-17 at 21:50 +0200, Michael Andreen wrote:
> > Coordinates are copied when auto-completing location, they are also
> > displayed and editable in maintab.
> > 
> > Signed-off-by: Michael Andreen <harv at ruin.nu>
> > ---
> > Doing a new try to see if anyone is interested in this, a fair bit of rewrites
> > after rebasing against current master.
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

More information about the subsurface mailing list