add dive - broken WIP for Tomaz

Tomaz Canabrava tcanabrava at
Thu Sep 19 04:02:48 UTC 2013

On Thu, Sep 19, 2013 at 1:43 AM, Dirk Hohndel <dirk at> wrote:

> As the subject indicates, this is primarily intended for Tomaz to see
> what damage I've been trying to do ^W^W^W^W^W^W I've been working on.

Oh noes. D:
*run in circles weaving hands*

> The idea is to use the planner to also simply add dives. And of course
> to then be able to edit / change dives like that with that same
> graphical editor later.
> Some of this works already, some of this has just been started.
> The biggest issue is introduced at the end where I switch back to having
> the maintab widget shown (that one is much more useful when adding a
> dive). But of course that widget has an existing edit mode that makes
> very different assumptions about what 'OK' and 'Undo' might mean.
> As the last commit indicates, this means that we need a third editMode
> (ADD) in which OK and Undo do the right thing and consolidate the latest
> two dive structures into one and add this consistently to the dive list.
> We also need to add a field to edit the dive date and time as well as a
> couple of other data points we might want to be able to enter
> (temperatures for example).
> Anyway, this is very much WIP and just intended for feedback.
> testForTomaz branch on (not on github)


The current widgets can work quite happly if you do:

1 - "Add Dive" on the planner
2 - by clicking on 'ok', dive goes to the Dive List and get's selected, by
clicking cancel, cancels it.
3 - When new dive's selected, user can edit the fields on the 'MainTab'
class ( terrible class name, I'll split those to have more meaningful
names. )
4 - If user wants to remove the newly added dive, right click on it, remove.

The way you envision is something different than that? if so, can you
explain here how do you feel it's the best way for the 'Add Dive' to work?

The current Planner and MainTab ( that I'll break into a few other widgets
in the future so it's easily ported to the view that luisa is working on )
has a lot of unrelated code ( Notes, Equipmennt, Dive Info and Stats ) that
I don't feel like keeping in the same class.


> /D
> _______________________________________________
> subsurface mailing list
> subsurface at
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the subsurface mailing list