add dive implementation pushed

Linus Torvalds torvalds at linux-foundation.org
Thu Sep 19 21:31:38 UTC 2013


On Thu, Sep 19, 2013 at 11:10 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> This uses part of the planner widget to allow the user to actually
> create a profile for their dive.
>
> Right now it has some SERIOUS shortcomings.

Here's the few less obvious bugs:

 - it doesn't update the dive number

 - if you're diving in imperial units, you're just screwed. The
planner gives you your depth in meters, and you'd better like it. Time
to learn SI units.

That said, it's kind of cool. It's definitely how dives should be
added. It might be better if it started you off with some random
multi-level profile that you got to edit (say, default to a roughly
20m dive for 45 minutes, with the last part of the dive at 10m, and
then let people fix it up), rather than a totally empty one, but I
think this is conceptually the right thing.

                        Linus


More information about the subsurface mailing list