add dive implementation pushed

Dirk Hohndel dirk at hohndel.org
Thu Sep 19 21:54:20 UTC 2013


On Thu, 2013-09-19 at 23:31 -0500, Linus Torvalds wrote:
> On Thu, Sep 19, 2013 at 11:10 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
> >
> > This uses part of the planner widget to allow the user to actually
> > create a profile for their dive.
> >
> > Right now it has some SERIOUS shortcomings.
> 
> Here's the few less obvious bugs:
> 
>  - it doesn't update the dive number

Yep. We get this wrong in master in several cases. But this one is
simply a matter of "I didn't even think of implementing this".

>  - if you're diving in imperial units, you're just screwed. The
> planner gives you your depth in meters, and you'd better like it. Time
> to learn SI units.

THIS IS METRIC AND YOU WILL LIKE IT! (spoken in heavy German accent)

Oops. Err. Yeah. I hadn't even looked at that as I am running Subsurface
in metric right now. I bet that the whole planner is only in metric as
well. Tomaz?

> That said, it's kind of cool. It's definitely how dives should be
> added. It might be better if it started you off with some random
> multi-level profile that you got to edit (say, default to a roughly
> 20m dive for 45 minutes, with the last part of the dive at 10m, and
> then let people fix it up), rather than a totally empty one, but I
> think this is conceptually the right thing.

Oh that's a COOL idea. I love it! And for good measure let's throw in a
deco stop.
Nice descent to 18m/60ft - 25 mins there
regular ascent to 9m/30ft - 15 mins there
regular ascent to 5m/15ft - 3 mins there
slow ascent to the surface

That shouldn't be too hard to do, either (famous last words). All it
takes should be to start with this diveplan instead of an empty one.
It's a bit too late for me to play with this tonight, though.

Something to look at tomorrow.

/D



More information about the subsurface mailing list