[PATCH] First row visibility fix in Dive List

Anton Lundin glance at acc.umu.se
Wed Apr 2 01:26:55 PDT 2014


Why do we got this adjustment of the header hight to begin with?

The only reason i can find is:

"I took the opportunity to fix the header height as well."

Its this adjustment in header height that hides the first trip marker in
the Android port, because the first trip row ends up behind the header.

I've looked at the tables in both Qt4 and Qt5 on Linux and Qt5 on
Android and all the tables looks still sane without this adjustment.

//Anton


On 02 April, 2014 - Andrey Zhdanov wrote:

> Fix height of first line in dive list by reducing header height by 3px.
> 
> Fixes #360
> 
> Signed-off-by: Andrey Zhdanov <andrjufka at gmail.com>
> ---
>  qt-ui/divelistview.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qt-ui/divelistview.cpp b/qt-ui/divelistview.cpp
> index d9f5eb9..9ad6dcf 100644
> --- a/qt-ui/divelistview.cpp
> +++ b/qt-ui/divelistview.cpp
> @@ -43,7 +43,7 @@ DiveListView::DiveListView(QWidget *parent) : QTreeView(parent), mouseClickSelec
>  	setContextMenuPolicy(Qt::DefaultContextMenu);
>  	header()->setContextMenuPolicy(Qt::ActionsContextMenu);
>  	const QFontMetrics metrics(defaultModelFont());
> -	header()->setMinimumHeight(metrics.height() + 10);
> +	header()->setMinimumHeight(metrics.height() + 7);
>  	header()->setStretchLastSection(true);
>  	QAction *showSearchBox = new QAction(tr("Show Search Box"), this);
>  	showSearchBox->setShortcut(Qt::CTRL + Qt::Key_F);
> -- 
> 1.8.5.2 (Apple Git-48)
> 
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

-- 
Anton Lundin	+46702-161604


More information about the subsurface mailing list