[PATCH] First row visibility fix in Dive List

Andrey Zhdanov andrjufka at gmail.com
Wed Apr 2 02:04:03 PDT 2014


> Why do we got this adjustment of the header hight to begin with?

First row is too close to header. 

> Its this adjustment in header height that hides the first trip marker in
> the Android port, because the first trip row ends up behind the header.

Can you show screenshot how it looks in the Android port?

> I've looked at the tables in both Qt4 and Qt5 on Linux and Qt5 on
> Android and all the tables looks still sane without this adjustment.

As it is stated in ticket #360, it is only mac problem. 

--
Andrey Zhdanov

> 
>> On 02 April, 2014 - Andrey Zhdanov wrote:
>> 
>> Fix height of first line in dive list by reducing header height by 3px.
>> 
>> Fixes #360
>> 
>> Signed-off-by: Andrey Zhdanov <andrjufka at gmail.com>
>> ---
>> qt-ui/divelistview.cpp | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/qt-ui/divelistview.cpp b/qt-ui/divelistview.cpp
>> index d9f5eb9..9ad6dcf 100644
>> --- a/qt-ui/divelistview.cpp
>> +++ b/qt-ui/divelistview.cpp
>> @@ -43,7 +43,7 @@ DiveListView::DiveListView(QWidget *parent) : QTreeView(parent), mouseClickSelec
>>    setContextMenuPolicy(Qt::DefaultContextMenu);
>>    header()->setContextMenuPolicy(Qt::ActionsContextMenu);
>>    const QFontMetrics metrics(defaultModelFont());
>> -    header()->setMinimumHeight(metrics.height() + 10);
>> +    header()->setMinimumHeight(metrics.height() + 7);
>>    header()->setStretchLastSection(true);
>>    QAction *showSearchBox = new QAction(tr("Show Search Box"), this);
>>    showSearchBox->setShortcut(Qt::CTRL + Qt::Key_F);
>> -- 
>> 1.8.5.2 (Apple Git-48)
>> 
>> _______________________________________________
>> subsurface mailing list
>> subsurface at hohndel.org
>> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
> 
> -- 
> Anton Lundin    +46702-161604


More information about the subsurface mailing list