[PATCH] First row visibility fix in Dive List

Dirk Hohndel dirk at hohndel.org
Wed Apr 2 10:18:58 PDT 2014


On Wed, 2014-04-02 at 11:51 +0200, Anton Lundin wrote:
> > > I've looked at the tables in both Qt4 and Qt5 on Linux and Qt5 on
> > > Android and all the tables looks still sane without this adjustment.
> > 
> > As it is stated in ticket #360, it is only mac problem. 
> > 
> 
> We should then make the layout fix only on the mac builds, and maybe try
> to get a layout fix upstream.

Fixes to only one platform should be conditional to that one platform.
And it would be really useful to understand why these constants are
there and if we really need different constants for different platforms.
Ideally we shouldn't and maybe these need to be filed as Qt bugs as
well.

I won't take this patch as unconditional change.

/D




More information about the subsurface mailing list