[PATCH] Fixes divelogs.de upload error #483

Dirk Hohndel dirk at hohndel.org
Sat Apr 5 07:46:21 PDT 2014


On Sat, 2014-04-05 at 14:15 +0530, Venkatesh Shukla wrote:
> Arguments 2 and 3 in fread() seemed to be exchanged because of which
> only one character was read into the temp xml file.
> Fixed it by exchange and replacing 1 by sizeof(char) to be sure.
> 
> 
> Signed-off-by: Venkatesh Shukla <venkatesh.shukla.eee11 at iitbhu.ac.in>
> ---
>  qt-ui/subsurfacewebservices.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/qt-ui/subsurfacewebservices.cpp
> b/qt-ui/subsurfacewebservices.cpp
> index b231173..e49cec9 100644
> --- a/qt-ui/subsurfacewebservices.cpp
> +++ b/qt-ui/subsurfacewebservices.cpp
> @@ -159,7 +159,7 @@ bool
> DivelogsDeWebServices::prepare_dives_for_divelogs(const QString
> &tempfile,


This patch got linewrapped. Please either attach patches or configure
your mail program so that it doesn't line wrap.

I could of course fix things up by hand but that isn't the point, is it?
Also, when you resubmit you could include the 
ACKed-by: Lubomir...
line :-)

/D






More information about the subsurface mailing list