[PATCH] Fixes divelogs.de upload error #483

Venkatesh Shukla venkatesh.shukla.eee11 at iitbhu.ac.in
Sat Apr 5 08:10:01 PDT 2014


On Sat, Apr 5, 2014 at 8:16 PM, Dirk Hohndel <dirk at hohndel.org> wrote:

> On Sat, 2014-04-05 at 14:15 +0530, Venkatesh Shukla wrote:
> > Arguments 2 and 3 in fread() seemed to be exchanged because of which
> > only one character was read into the temp xml file.
> > Fixed it by exchange and replacing 1 by sizeof(char) to be sure.
> >
> >
> > Signed-off-by: Venkatesh Shukla <venkatesh.shukla.eee11 at iitbhu.ac.in>
> > ---
> >  qt-ui/subsurfacewebservices.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >
> > diff --git a/qt-ui/subsurfacewebservices.cpp
> > b/qt-ui/subsurfacewebservices.cpp
> > index b231173..e49cec9 100644
> > --- a/qt-ui/subsurfacewebservices.cpp
> > +++ b/qt-ui/subsurfacewebservices.cpp
> > @@ -159,7 +159,7 @@ bool
> > DivelogsDeWebServices::prepare_dives_for_divelogs(const QString
> > &tempfile,
>
>
> This patch got linewrapped. Please either attach patches or configure
> your mail program so that it doesn't line wrap.
>
> I could of course fix things up by hand but that isn't the point, is it?
> Also, when you resubmit you could include the
> ACKed-by: Lubomir...
> line :-)
>
> /D
>
>
I am attaching the updated patch.

-- 

*Venkatesh Shukla *
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140405/3e6f8ba4/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fixes-divelogs.de-upload-error-483.patch
Type: text/x-patch
Size: 1265 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140405/3e6f8ba4/attachment.bin>


More information about the subsurface mailing list