[PATCH] Fix HTML errors

Miika Turkia miika.turkia at gmail.com
Sat Apr 5 22:14:40 PDT 2014


- There needs to be a space between HTML attributes.
- Ampersand must be encoded on URL addresses
- Div element is non-void, so it cannot be self closed

Signed-off-by: Miika Turkia <miika.turkia at gmail.com>
---
 worldmap-save.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/worldmap-save.c b/worldmap-save.c
index 36ee943..e867846 100644
--- a/worldmap-save.c
+++ b/worldmap-save.c
@@ -122,9 +122,9 @@ void insert_css(struct membuffer *b)
 
 void insert_javascript(struct membuffer *b)
 {
-	put_string(b, "<script type=\"text/javascript\"src=\"");
+	put_string(b, "<script type=\"text/javascript\" src=\"");
 	put_string(b, getGoogleApi());
-	put_string(b, "&sensor=false\">\n</script>\n<script type=\"text/javascript\">\nvar map;\n");
+	put_string(b, "&sensor=false\">\n</script>\n<script type=\"text/javascript\">\nvar map;\n");
 	put_format(b, "function initialize() {\nvar mapOptions = {\n\t%s,", map_options);
 	put_string(b, "rotateControl: false,\n\tstreetViewControl: false,\n\tmapTypeControl: false\n};\n");
 	put_string(b, "map = new google.maps.Map(document.getElementById(\"map-canvas\"),mapOptions);\nvar markers = new Array();");
@@ -139,7 +139,7 @@ void export(struct membuffer *b)
 	insert_html_header(b);
 	insert_css(b);
 	insert_javascript(b);
-	put_string(b, "\t</head>\n<body>\n<div id=\"map-canvas\"/>\n</body>\n</html>");
+	put_string(b, "\t</head>\n<body>\n<div id=\"map-canvas\"></div>\n</body>\n</html>");
 }
 
 void export_worldmap_HTML(const char *file_name)
-- 
1.8.3.2



More information about the subsurface mailing list