[PATCH] Removing unneeded refrences to QSettings

Dirk Hohndel dirk at hohndel.org
Tue Apr 15 11:21:06 PDT 2014


On Fri, 2014-04-11 at 23:54 +0200, Gehad wrote:
> The patch attached changes some QSettings refrences to prefs struct.
> Some are not changed yet like the "rulergraph" setting , because I 
> didn't implement the setter function yet.
> 

Sorry I missed this one.

Some comments:

a) please explain the bool->short conversion in the commit message
b) please don't change the name of options in the settings - that causes
issues for the existing users! change the prefs member instead (even if
we might not love the names... at least now they are consistent... it's
my own fault for not paying much more attention to this when it got
added)
c) make sure that none of this breaks the whole Apply / Quite without
saving semantics

/D




More information about the subsurface mailing list