[PATCH] Removing unneeded refrences to QSettings

Gehad gehadelrobey at gmail.com
Tue Apr 15 13:43:19 PDT 2014


On 04/15/2014 08:21 PM, Dirk Hohndel wrote:
> On Fri, 2014-04-11 at 23:54 +0200, Gehad wrote:
>> The patch attached changes some QSettings refrences to prefs struct.
>> Some are not changed yet like the "rulergraph" setting , because I
>> didn't implement the setter function yet.
>>
> Sorry I missed this one.
>
> Some comments:
>
> a) please explain the bool->short conversion in the commit message
> b) please don't change the name of options in the settings - that causes
> issues for the existing users! change the prefs member instead (even if
> we might not love the names... at least now they are consistent... it's
> my own fault for not paying much more attention to this when it got
> added)
> c) make sure that none of this breaks the whole Apply / Quite without
> saving semantics
>

I Fixed these issues in the attached patch.

-- 
Regards,
Gehad Elrobey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Renaming-the-prefs-struct-members-to-be-consistent-w.patch
Type: text/x-patch
Size: 20012 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140415/be9aefb8/attachment.bin>


More information about the subsurface mailing list