[PATCH] make git save commit messages more informative

Linus Torvalds torvalds at linux-foundation.org
Sun Apr 27 20:16:02 PDT 2014


On Sun, Apr 27, 2014 at 8:08 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> That's not the number of dives, it's the last dive number.

Actually, it's one or the other.

If the last dive has a number, it is the dive number, otherwise it's
the number of dives we have:

+       int nr = dive_table.nr;
..
+               if (dive->number)
+                       nr = dive->number;

But in both cases it's arguably the number of dives you've had.

If you've logged all your dives (like you have), the two numbers are
presumably the same.

If you don't have all dives logged but *do* have dive numbers, I think
the number you show for the last dive is your "number of dives", it's
just that you're missing some (so it's not necessarily the same as the
number of dives you've saved in subsurface).

But hey, it's all semantics. I think I'd rather show the same number
that shows in the dive log list if we have one.

            Linus


More information about the subsurface mailing list