[Patch] Enforce end pressure not to be above starting pressure

[camjesus]

If there's discussion about a non-critical feature, then, I guess best is to leave it alone. To me it seems weird to have EP>>SP but hey, "don't fix if it ain't broken..."
 

CJ

-----Original Message-----
From: subsurface [mailto:subsurface-bounces at hohndel.org] On Behalf Of Linus Torvalds
Sent: domingo, 3 de Agosto de 2014 00:25
To: Linus Torvalds; Robert C. Helling; Subsurface Mailing List
Subject: Re: [Patch] Enforce end pressure not to be above starting pressure

On Sat, Aug 2, 2014 at 4:13 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> I usually think the same, but we have several people filing bugs that 
> complain that you can enter silly pressure values (start at 230bar, 
> end at
> 1200bar)
>
> There's no way we'll make everyone happy.

How about showing them in red or something? We already do special things for pressure: we set a different font when the pressure comes from the samples, for example.

Here's a patch that does exactly that. It works, but I wouldn't suggest taking it as-is simply because of the whole hardcoding of red-vs-white background. There's presumably some way to set it to default values - somebody who knows more about Qt would know.

I really think it's wrong to try to say "you can't do that". And part of it really is that you might want to *fix* things, and then having to fix it in "just the right order" (because the wrong order results in higher end pressures than beginning pressures _momentarily_) is actually really annoying.

Making it visually clear that "you did something wrong" is a *much* better option, I think.

             Linus