anyone with access to Windows (real or VM), please test...

Thiago Macieira thiago at macieira.org
Sun Aug 3 06:20:37 PDT 2014


On Sunday 03 August 2014 10:17:56 Miika Turkia wrote:
> -       QString filename = QDir::tempPath() + "/import-" +
> QString::number(qrand() % 99999999) + ".dld"; 
> +       QString filename =
> QDir::tempPath() + QDir::separator() + "import-" + QString::number(qrand()
> % 99999999) + ".dld";
>   	      if (prepare_dives_for_divelogs(filename, selected)) {
>                 QFile f(filename);

This change is not necessary for the QFile opening on the last line and 
prepare_dives_for_divelogs does pass through QFile::encodeName but that itself 
isn't enough.

We want prepare_dives_for_divelogs to do QDir::toNativeSeparators.
-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358



More information about the subsurface mailing list