anyone with access to Windows (real or VM), please test...

[Miika Turkia]

On Sun, Aug 3, 2014 at 4:20 PM, Thiago Macieira <thiago at macieira.org> wrote:

> On Sunday 03 August 2014 10:17:56 Miika Turkia wrote:
> > -       QString filename = QDir::tempPath() + "/import-" +
> > QString::number(qrand() % 99999999) + ".dld";
> > +       QString filename =
> > QDir::tempPath() + QDir::separator() + "import-" +
> QString::number(qrand()
> > % 99999999) + ".dld";
> >             if (prepare_dives_for_divelogs(filename, selected)) {
> >                 QFile f(filename);
>
> This change is not necessary for the QFile opening on the last line and
> prepare_dives_for_divelogs does pass through QFile::encodeName but that
> itself
> isn't enough.
>
> We want prepare_dives_for_divelogs to do QDir::toNativeSeparators.
>

I might not be fully following you, but would this version be OK?

miika
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140803/23e85bbc/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Try-to-fix-divelogs-upload-on-Windows.patch
Type: text/x-patch
Size: 1064 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140803/23e85bbc/attachment.bin>