anyone with access to Windows (real or VM), please test...

[Linus Torvalds]

On Sun, Aug 3, 2014 at 10:54 AM, "Paul-Erik Törrönen"
<poltsi at 777-team.org> wrote:
>
> There are missing strings/numbers in the dialog when doing upload from a
> dive computer. The selected language is Finnish. See attached screenshot
> for details. There is a string at the bottom saying 'Sukellus $d: $d.
> $skuuta $04d'.

It looks like the windows vsnprintf() function doesn't understand
positional parameters.

I'm not horribly surprised, and looking around, this is actually the
only place we use those things.

I would suggest perhaps screwing up the Finnish translation a bit in
order to avoid the positional parameter feature. Patch attached.

It should result in (untested)

 "Sukellus 5: Maaliskuun 15. päivä 2014"

rather than

 "Sukellus 5: 15. Maaliskuuta 2014"

so it's perhaps less normal Finnish, but it's certainly better than
having the "$d" instead of the proper number due to using a somewhat
special feature of the C stdio library

Hmm? Or does that "Kuukauden n. päivä" format sound really wrong to people?

                Linus
-------------- next part --------------
 translations/subsurface_fi_FI.ts | 2 +-
 1 file changed, 1 insertions(+), 1 deletions(-)

diff --git a/translations/subsurface_fi_FI.ts b/translations/subsurface_fi_FI.ts
index 08664b397598..ba336bf4b299 100644
--- a/translations/subsurface_fi_FI.ts
+++ b/translations/subsurface_fi_FI.ts
@@ -3566,7 +3566,7 @@ Keski</translation>
     <message>
         <location filename="../libdivecomputer.c" line="438"/>
         <source>Dive %d: %s %d %04d</source>
-        <translation>Sukellus %1$d: %3$d. %2$skuuta %4$04d</translation>
+        <translation>Sukellus %d: %skuun %d. päivä %04d</translation>
     </message>
     <message>
         <location filename="../libdivecomputer.c" line="443"/>