anyone with access to Windows (real or VM), please test...

Linus Torvalds torvalds at linux-foundation.org
Sun Aug 3 12:25:09 PDT 2014


On Sun, Aug 3, 2014 at 12:09 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Sun, Aug 03, 2014 at 11:13:23AM -0700, Linus Torvalds wrote:
>>
>> It looks like the windows vsnprintf() function doesn't understand
>> positional parameters.
>
> Lovely :-/

Actually, it looks like it might be about
"translate("gettextFromC",..)" instead. So it might not be vsnprintf()
itself. I didn't try to follow that thing, it seems to be defined to
trGettext().

But it does work for me on Fedora, so regardless of where the problem
is, there's something windows-specific there.

> Missing commit message and SOB... but then again - we'd want to change
> that on Transifex, anyway.

I don't have a Transifex account, but yes.

That said, having actually looked at the Finnish result, the lack of
divelist translation looks worse.

So I'd argue for the transifex equivalent of the attached patch instead.

              Linus
-------------- next part --------------
 translations/subsurface_fi_FI.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/translations/subsurface_fi_FI.ts b/translations/subsurface_fi_FI.ts
index 08664b397598..ec707ee28b75 100644
--- a/translations/subsurface_fi_FI.ts
+++ b/translations/subsurface_fi_FI.ts
@@ -3566,7 +3566,7 @@ Keski</translation>
     <message>
         <location filename="../libdivecomputer.c" line="438"/>
         <source>Dive %d: %s %d %04d</source>
-        <translation>Sukellus %1$d: %3$d. %2$skuuta %4$04d</translation>
+        <translation>Sukellus %d: %skuun %d. päivä %04d</translation>
     </message>
     <message>
         <location filename="../libdivecomputer.c" line="443"/>
@@ -4077,12 +4077,12 @@ EADD: %d%s
     <message>
         <location filename="../qt-gui.cpp" line="427"/>
         <source>%1 %2 (%3 dives)</source>
-        <translation>%1 %2 (%3 dives)</translation>
+        <translation>%1kuu %2 (%3 sukellusta)</translation>
     </message>
     <message>
         <location filename="../qt-gui.cpp" line="432"/>
         <source>%1 %2 (1 dive)</source>
-        <translation>%1 %2 (1 dive)</translation>
+        <translation>%1kuu %2 (1 sukellus)</translation>
     </message>
     <message>
         <location filename="../dive.c" line="19"/>


More information about the subsurface mailing list