My progress in HTML export.

Gehad Elrobey gehadelrobey at gmail.com
Mon Aug 4 07:03:15 PDT 2014


Hi Miika,

Sorry for the delay, I had some family vacations this week.
I Implemented the yearly statistics into the HTML exports (Patches are
attached), also there are some patches not applied to current master yet..
I am waiting your feedback.

Regards,
Gehad


On Mon, Jul 28, 2014 at 5:14 PM, Miika Turkia <miika.turkia at gmail.com>
wrote:

> Thanks, you had one 'return' missing, which I added and did some rewording
> on the commit messages.
>
> The lines on the horizontal axis are a bit weird currently. Shown on the
> attached screenshot. The depth and pressure units get misaligned due to the
> static temperature fix (I guess).
>
> miika
>
>
>
> On Sun, Jul 27, 2014 at 11:01 PM, Gehad Elrobey <gehadelrobey at gmail.com>
> wrote:
>
>> I Attached four patches that fix the mentioned bugs. I ll still work on
>> more improvements for the current javascript code.
>>
>> Regards,
>> Gehad
>>
>>
>> On Fri, Jul 25, 2014 at 8:02 AM, Miika Turkia <miika.turkia at gmail.com>
>> wrote:
>>
>>> On Thu, Jul 24, 2014 at 10:29 PM, Gehad Elrobey <gehadelrobey at gmail.com>
>>> wrote:
>>>
>>>>
>>>> I attached a patch with two more fixes.
>>>> Now most of the bugs list seems to be resolved.
>>>>
>>>
>>> It seems that the temperature graph is not drawn, if the temperature is
>>> constant the whole dive.
>>>
>>> The layout seems to change for me when I open a dive on the divelist.
>>> This is due to scrollbar appears on the browser window. If you could come
>>> up with something that keeps the layout the same in this case. This
>>> requires on my screen that I export just a few dives, having 10 dives on
>>> the page causes the scroll bar to be there to begin with.
>>>
>>> Could give a - as value for such events that don't have any sensible
>>> values. I suppose that heading is the only event where value 0 makes sense.
>>>
>>> Dive equipments seems to only include the cylinder information. It could
>>> have also weight and suite... or the title should be changed to cylinder.
>>>
>>>
>>>
>>>> what do you recommend to be added for now? and what things are missing
>>>> or need to be fixed as a priority?
>>>>
>>>
>>> A statistics page could be next one to implement. Yearly and trip based
>>> stats of the key values. You could also implement something that is
>>> currently missing from Subsurface GUI - statistics of how many specific
>>> tags are there, how many dives with certain buddies etc. One could come up
>>> with quite a few ideas about how to graph different statistics out of the
>>> date that is kept... But take small steps implementing this stuff. Better
>>> to have basic stuff properly implemented first than a whole lot of
>>> incomplete mess...
>>>
>>>
>>>> On Mon, Jul 21, 2014 at 7:32 AM, Miika Turkia <miika.turkia at gmail.com>
>>>> wrote:
>>>>
>>>>> On Mon, Jul 21, 2014 at 8:16 AM, Gehad Elrobey <gehadelrobey at gmail.com
>>>>> > wrote:
>>>>>
>>>>>>
>>>>>> Hi miika,
>>>>>>
>>>>>> On Sun, Jul 20, 2014 at 8:02 AM, Miika Turkia <miika.turkia at gmail.com
>>>>>> > wrote:
>>>>>>
>>>>>>> New bugs I spotted:
>>>>>>>
>>>>>>> - The tooltip on temperature graphs shows actually the time
>>>>>>> (concatenated with temperature unit).
>>>>>>>
>>>>>>
>>>>>> what is it supposed to show? I think this is consistent will all the
>>>>>> other curves in the profile.
>>>>>>
>>>>>
>>>>>  It should show the temperature value. The temperature graph is drawn
>>>>> based on the temperature correctly, but the tooltip shows time since start
>>>>> of the time, not the temperature.
>>>>>
>>>>
>>>> I Can't reproduce this at all, this is working correctly with me in all
>>>> the dives I have (Please see the attachments).
>>>>
>>>
>>> Seems that I mis-read the value - thought the time is part of the
>>> temperature. Maybe you could use colon instead of comma to separate the
>>> time from the actual value. It would be a bit clearer that it is not 8,6 C
>>> :D
>>>
>>> miika
>>>
>>>>
>>>>
>>>>>
>>>>>
>>>>>> I Also fixed the previous patches, and attached some new patches with
>>>>>> them.
>>>>>> There are still three bugs that I am working on them now.
>>>>>>
>>>>>
>>>>> Thanks, I'll have a look later.
>>>>>
>>>>>
>>>>>>  - I am not sure about the search of location - e.g. if I write
>>>>>>> "Mexico somethingthatdoesnotexist", I get all the locations in Mexico.
>>>>>>> - Zooming in (ctrl++) and out (ctrl+-) and restoring zoom level
>>>>>>> (ctrl+0) on firefox does not rescale the graph properly
>>>>>>> - The heading and gaschange switches should use the value field from
>>>>>>> the event, not the type field (type is still internal to subsurface, and
>>>>>>> does not provide any useful information to the users, on the other hand
>>>>>>> value would e.g. tell what gas we changed to)
>>>>>>>
>>>>>>
>>>>>> Regarding the event value, is exporting the event value as a number
>>>>>> is useful? or there is some enum strings that must be shown instead?
>>>>>>
>>>>>
>>>>> The heading is degrees, as in compass.
>>>>>
>>>>> The gas change event's value contains the o2 per centage, of the gas
>>>>> mix, or it can also contain the o2 and he content. Low order bits being o2
>>>>> and high order bits the he:
>>>>> he = cur_event.value >> 16
>>>>> o2 = cur_event.value & 0xffff
>>>>>
>>>>> miika
>>>>>
>>>>>
>>>>>>  - If I go to next dive on detailed view, and hit one extra right
>>>>>>> arrows after reaching the last dive, first click on left does not change
>>>>>>> the selection, only re-clicking on left does
>>>>>>>
>>>>>>> I'll still do a bit of poking around once I have more time...
>>>>>>>
>>>>>>> miika
>>>>>>>
>>>>>>>
>>>>>>> On Sat, Jul 19, 2014 at 6:30 AM, Gehad Elrobey <
>>>>>>> gehadelrobey at gmail.com> wrote:
>>>>>>>
>>>>>>>> I Attached some bug fixes, Still working on the remaining bugs.
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Gehad.
>>>>>>>>
>>>>>>>>
>>>>>>>> On Tue, Jul 15, 2014 at 11:22 PM, Tomaz Canabrava <
>>>>>>>> tcanabrava at kde.org> wrote:
>>>>>>>>
>>>>>>>>> On Tue, Jul 15, 2014 at 4:31 PM, Anton Lundin <glance at acc.umu.se>
>>>>>>>>> wrote:
>>>>>>>>> > On 15 July, 2014 - Anton Lundin wrote:
>>>>>>>>> >
>>>>>>>>> >> On 15 July, 2014 - Miika Turkia wrote:
>>>>>>>>> >>
>>>>>>>>> >> > A few more bugs:
>>>>>>>>> >> > - Trimix dives are missing He content (use e.g. test20.xml
>>>>>>>>> for testing
>>>>>>>>> >> > purposes) - Reported by Roberto, but mailing list was not
>>>>>>>>> included
>>>>>>>>> >>
>>>>>>>>> >> Gaah. This is code that uses the event data straight off. In
>>>>>>>>> the case of
>>>>>>>>> >> SAMPLE_EVENT_GASCHANGE especially we need to map the event to
>>>>>>>>> the
>>>>>>>>> >> available cylinders and that way figure out which gas we are
>>>>>>>>> using.
>>>>>>>>> >>
>>>>>>>>> >> Almost every place where we use get_gasmix_from_event we should
>>>>>>>>> be using
>>>>>>>>> >> get_cylinder_index instead and grab the "real" gasmix from the
>>>>>>>>> cylinder,
>>>>>>>>> >> except the case where get_gasmix_from_event is called from
>>>>>>>>> >> get_cylinder_index =)
>>>>>>>>> >>
>>>>>>>>> >>
>>>>>>>>> >> This was more work than anticipated when i first gave it a
>>>>>>>>> stab. If no
>>>>>>>>> >> one else untangles this I'll give it another stab later.
>>>>>>>>> >>
>>>>>>>>> >>
>>>>>>>>> >
>>>>>>>>> > Gaah 2.
>>>>>>>>> >
>>>>>>>>> > I of course miss-read the report and i was talking about what we
>>>>>>>>> write
>>>>>>>>> > in the regular-non-html-ui.
>>>>>>>>> >
>>>>>>>>> > I found another bug.
>>>>>>>>>
>>>>>>>>> :P
>>>>>>>>>
>>>>>>>>> > //Anton
>>>>>>>>> _______________________________________________
>>>>>>>>> subsurface mailing list
>>>>>>>>> subsurface at hohndel.org
>>>>>>>>> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140804/0f685aab/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-HTML-don-t-replot-the-graph-if-not-plotted-before.patch
Type: text/x-patch
Size: 799 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140804/0f685aab/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-HTML-Make-export-statistics-optional.patch
Type: text/x-patch
Size: 5372 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140804/0f685aab/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-HTML-add-Yearly-Statistics-view-to-the-HTML-export.patch
Type: text/x-patch
Size: 6087 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140804/0f685aab/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-HTML-export-yearly-statistics-to-JSON-files.patch
Type: text/x-patch
Size: 4025 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140804/0f685aab/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-HTML-add-weight-systems-to-the-dive-equipments-secti.patch
Type: text/x-patch
Size: 3302 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140804/0f685aab/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-HTML-Fix-constant-value-temperature-curve.patch
Type: text/x-patch
Size: 864 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140804/0f685aab/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-HTML-fix-jqplot-memory-leaks-when-replot-the-profile.patch
Type: text/x-patch
Size: 762 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140804/0f685aab/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-HTML-Fix-event-value-fields.patch
Type: text/x-patch
Size: 1923 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140804/0f685aab/attachment-0015.bin>


More information about the subsurface mailing list