test binaries for Beta 5

Dirk Hohndel dirk at hohndel.org
Wed Aug 6 09:06:44 PDT 2014


On Wed, Aug 06, 2014 at 08:56:00AM -0700, Linus Torvalds wrote:
> On Wed, Aug 6, 2014 at 7:54 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
> >
> > BTW: the 0 l/m crap is fixed. Just pushed a commit for this.
> 
> Ugh.
> 
> I sent a more correct patch just last week or so, and said "this is
> likely not a 4.2 issue". And then you "fix" the same bug, but don't
> bother to do it right.

Hmm. Need to look back for that fix.
The last week has been rather frustrating for me.
I'm rather unhappy with the beta / release process.

> Your fix continues to special-case the first gas ("unknown" vs empty
> string). And it continues to get confused about the gas list, because
> "get_gaslist()" will show all cylinders that have any use, but the
> other gas loops in updateDiveInfo() will stop at the first gas that
> has no pressure change, which is not the same thing. So if you don't
> actually breathe your first gas for some reason (or just don't have
> gas use for it), you'll also not see SAC-rates for the subsequent
> gases that *did* have gas use information

That seems wrong.

> And now my patch that actually got these cases right doesn't apply any more.

Well, let's revert my amateur patch and use the one from the expert.
Let me go find it.

/D


More information about the subsurface mailing list