please resend your patches...CCR

[Robert Helling]

On 12.08.2014, at 10:56, Willem Ferguson <willemferguson at zoology.up.ac.za> wrote:

Willem,

> So I need advice from the experts in this forum. What is the most
> sensible way to go about this?

my irrelevant opinion is the following: First of all, profile.c is already quite long with 1.5klines of code, why not take the gas handling functions to a separate file (as a first patch)?

Then, is it really a good idea to do the loop over gases (dillutant and oxygen) in the outer functions and call the inner functions twice? Why not do the loop only in the innermost function, e.g. in get_pr_interpolate_data interpolate possibly two rather than one gas? Then you don’t have to apply changes everywhere?

Best
Robert

-- 
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
                      http://www.atdotde.de

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140812/5288668c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140812/5288668c/attachment.sig>