Partial push of Josh's configure-dive-computer GSoC project

[Thiago Macieira]

On Thursday 14 August 2014 12:15:18 Anton Lundin wrote:
> Program received signal SIGSEGV, Segmentation fault.
> ConfigureDiveComputerDialog::populateDeviceDetails
> (this=this at entry=0x23bd1a0) at
> ../subsurface/qt-ui/configuredivecomputerdialog.cpp:141
> 141             gas1.oxygen = ui->ostc3GasTable->item(0,
> 1)->text().toInt(); (gdb) where
> #0  ConfigureDiveComputerDialog::populateDeviceDetails
> (this=this at entry=0x23bd1a0) at
> ../subsurface/qt-ui/configuredivecomputerdialog.cpp:141
> #1  0x00000000004f5eb8 in
> ConfigureDiveComputerDialog::on_backupButton_clicked (this=0x23bd1a0) at
> ../subsurface/qt-ui/configuredivecomputerdialog.cpp:397

I managed to reproduce this crash. Valgrind log indicates it's a null-pointer 
dereference.

==51045== Invalid read of size 8
==51045==    at 0x539AC4: QTableWidgetItem::text() const (qtablewidget.h:108)
==51045==    by 0x535A24: ConfigureDiveComputerDialog::populateDeviceDetails() 
(configuredivecomputerdialog.cpp:141)
==51045==    by 0x539246: 
ConfigureDiveComputerDialog::on_backupButton_clicked() 
(configuredivecomputerdialog.cpp:397)
==51045==    by 0x554891: 
ConfigureDiveComputerDialog::qt_static_metacall(QObject*, QMetaObject::Call, 
int, void**) (moc_configuredivecomputerdialog.cpp:76)
==51045==    by 0x5549B9: 
ConfigureDiveComputerDialog::qt_metacall(QMetaObject::Call, int, void**) 
(moc_configuredivecomputerdialog.cpp:118)
==51045==    by 0x9DEF635: QMetaObject::metacall(QObject*, QMetaObject::Call, 
int, void**) (qmetaobject.cpp:245)
==51045==    by 0x9E05646: QMetaObject::activate(QObject*, QMetaObject const*, 
int, void**) (qobject.cpp:3569)
==51045==    by 0x9882FD5: QAbstractButton::clicked(bool) 
(moc_qabstractbutton.cpp:219)
==51045==    by 0x94FAD63: QAbstractButtonPrivate::emitClicked() 
(qabstractbutton.cpp:548)
==51045==    by 0x94FACD1: QAbstractButtonPrivate::click() 
(qabstractbutton.cpp:541)
==51045==    by 0x94FC1A6: QAbstractButton::mouseReleaseEvent(QMouseEvent*) 
(qabstractbutton.cpp:1123)
==51045==    by 0x9077D9F: QWidget::event(QEvent*) (qwidget.cpp:8376)
==51045==  Address 0x0 is not stack'd, malloc'd or (recently) free'd

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358