[PATCH] HTML export fixes

Miika Turkia miika.turkia at gmail.com
Thu Aug 14 09:37:04 PDT 2014


On Thu, Aug 14, 2014 at 7:10 PM, Dirk Hohndel <dirk at hohndel.org> wrote:

>
> - mouse hover overlay:
>   the lack of units for time is a bit confusing, at first I wondered why I
>   had 2,185bar in my tank at the beginning of the dive (and was briefly
>   wondering about a bar/psi mixup).
>

Totally agree, a colon (:) would also help as I have mentioned earlier.
Anyway "2s: 185bar" would probably make this very obvious.

>
> - Location / undefined
>   with current master I get "Date:... Time:... undefined:...
>  Coordinates:..."
>   I bet that's supposed to say "Divesite" or "Location" or something :-)
>

This is partly my fault as I fixed typo on Location with the previous set
of patches. Somehow the same typo sneaked back in with this set of patches.
I have attached a typo fix here again...

>
> Now I realize this reads like a long list of complaints. Please take it as
> input in making things even better. Some of them (like the "undefined"
> instead of location) should be trivial fixes - actually most of them with
> maybe the exception of imperial units should be fairly easy, but that's
> the point. These are all minor issues in an overall very successful
> project!
>

At least you remember to give praise where it is due. I have also been
happy with Gehad's progress and results!

One thing that should have been done differently is bugs and enhancement
requests. We should have created tickets on bugtracker of all the issues
instead of just listing them on emails. I haven't been able to follow all
the issues I have mentioned and I am sure it is even harder for Gehad...

miika
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140814/a05ad64b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-typo.patch
Type: text/x-patch
Size: 2687 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140814/a05ad64b/attachment.bin>


More information about the subsurface mailing list