[PATCH] HTML export fixes

[Gehad Elrobey]

On Thu, Aug 14, 2014 at 7:10 PM, Dirk Hohndel <dirk at hohndel.org> wrote:

>
> I just pushed out the latest changes.
>
> I like the progress, but there are a couple of small things that I find
> odd...
>
> - naming of export:
>   I think it would make much more sense to name the exports
>   <filename_given>.html
>   <filename_given>_files
>
>   So if the user gives a filename with a suffix, remove the suffix and
>   replace it with "_files" for the data directory.
>   And if the user gives a filename with no suffix, add ".html" for the
>   main file (and add "_files" for the folder).
>
> - mouse hover overlay:
>   the lack of units for time is a bit confusing, at first I wondered why I
>   had 2,185bar in my tank at the beginning of the dive (and was briefly
>   wondering about a bar/psi mixup).
>
> - units
>   speaking of which: no imperial units? That's not a requirement for GSOC,
>   of course, but would be nice to have.
>

That was one of my Todos after GSOC.


>
> - Acronyms
>   SAC, OTU, and CNS should be uppercase
>
> - Gas list
>   While air gets '0' as O₂ value (for reasons Linus has explained many
>   times), we should show "Air" and not an O₂ of "--"
>

I don't understand this, do I have to change the header to Air instead of
O2? or Change the empty value?


>
> - Location / undefined
>   with current master I get "Date:... Time:... undefined:...
> Coordinates:..."
>   I bet that's supposed to say "Divesite" or "Location" or something :-)
>
> - precision
>   this is truly a trivial nitpick... but giving pressure to two digits
>   after the decimal point is a bit excessive (189.44 bar). I can see a
>   point in giving one decimal as that gives similar "precision" as psi.
>   I would also be fine with whole bar (no decimal) and psi to multiples of
>   10 or something. In the main app we are a bit inconsistent at this time,
>   that's something I wanted to fix before 4.2 and forgot about. We are
>   showing whole bars but also whole psi instead of rounding to the nearest
>   10 psi. There simply is no pressure sensor with 4 significant digits in
>   accuracy. So this is fake precision.
>
>   Similarly for weights. I report my weights in pounds (US pounds) and
>   since Subsurface shows me kg I get things like "2.722kg" which really
>   makes no sense. It's 6lbs or 2.7kg.
>
>
>
> Now I realize this reads like a long list of complaints. Please take it as
> input in making things even better. Some of them (like the "undefined"
> instead of location) should be trivial fixes - actually most of them with
> maybe the exception of imperial units should be fairly easy, but that's
> the point. These are all minor issues in an overall very successful
> project!
>
>
Thanks,
Gehad


> /D
>
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20140816/3651487b/attachment.html>