[PATCH] Print nice names for nitrox mixes in the divelist

Dirk Hohndel dirk at hohndel.org
Sat Aug 16 06:52:31 PDT 2014


On Sat, Aug 16, 2014 at 03:47:05PM +0200, Anton Lundin wrote:
> >@@ -453,9 +454,9 @@ char *get_dive_gas_string(struct dive *dive)
> > 			snprintf(buffer, MAX_GAS_STRING, "%d/%d", o2, he);
> > 		else if (o2)
> > 			if (o2 == o2low)
> >-				snprintf(buffer, MAX_GAS_STRING, "%d", o2);
> >+				snprintf(buffer, MAX_GAS_STRING, "EAN%d", o2);
> > 			else
> >-				snprintf(buffer, MAX_GAS_STRING, "%d" UTF8_ELLIPSIS "%d", o2low, o2);
> >+				snprintf(buffer, MAX_GAS_STRING, "EAn%d" UTF8_ELLIPSIS "EAN%d", o2low, o2);
> 
> EAn typo.
> 
> > 		else
> > 			strcpy(buffer, translate("gettextFromC", "air"));
> > 	}
> 
> 
> Shouldn't there be possible to do something nicer with
> const char *gasname(const struct gasmix *gasmix) ?

Well, we do the odd "summarizing of gases" here. Sure, we could use
gasname for parts of it, but I don't think that would make it any easier
to read.

But great catch on the "EAn" type :-)

/D


More information about the subsurface mailing list