Partial push of Josh's configure-dive-computer GSoC project

Thiago Macieira thiago at macieira.org
Sun Aug 17 10:07:36 PDT 2014


On Thursday 14 August 2014 10:16:37 Dirk Hohndel wrote:
> > You can conditionally build on the DC_VERSION_CHECK(0,5,0) macro. That
> > would only break if you checkout a much older commit on the master
> > branch. But why would anyone want do that? The master branch is an
> > unstable development branch for a reason. But as promised I'm not
> > planning any backwards incompatible changes (from v0.4.x) until v0.5 is
> > released.
> 
> Good point. I built the Windows and Mac binaries with top of master
> because it added quite a few fixes over what was in the 0.4 branch.
> And we can add a note in the README file when I pull this code that from
> now on we require 0.5-devel or newer, including that specific commit.

I've now added the #ifdefs.

Subsurface will now compile with libdivecomputer 0.4.x, but will always 
complain that the dive computer configurations for OSTC3 are not supported.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358



More information about the subsurface mailing list