[PATCH v2 1/1] Update Subsurface with the updated QSysInfo from Qt 5.4

[Dirk Hohndel]

On Sun, Aug 17, 2014 at 09:17:45PM -0700, Thiago Macieira wrote:
> On Sunday 17 August 2014 21:15:13 Thiago Macieira wrote:
> > +       // we need to replace all other ':' with ' ' so that this is easy to
> > parse +       // in the "pretty" parts; everything else is an identifier
> > +       QString userAgent = QString("Subsurface:%1:%2:%3:%4")
> > +                           .arg(VERSION_STRING,
> > +                               
> > SubsurfaceSysInfo::prettyProductName().replace(':', ' '),
> > +                                arch,
> > +                                uiLanguage(NULL)),
> 
> Looks like I forgot to save the file before commit & rebase. The last line here 
> needs to end in ; not a comma.
> 
> Can you fix it or should I send a new patch?

CHRIST. Please. I am NOT INTERESTED in changing what is sent in the survey
or as the User Agent string.

Now the survey changed to something like this:

survey?ssrfVers=4.2-55-gc935ffcca386&kernelType=linux&kernelVersion=3.15.8-200.fc20.x86_64&productType=fedora&productVersion=20&buildCpuArchitecture=x86_64&currentCpuArchitecture=x86_64&uiLang=en-US&suggestion=&recreational=1&tech=1&planning=1&download=1&divecomputer=0&manual=0&companion=1"

instead of

survey?ssrfVers=4.2.0&prettyOsName=OS%20X%20Mavericks%20(10.9)&appCpuArch=x86_64&uiLang=en&recreational=0&tech=1&planning=1&download=1&divecomputer=1&manual=0&companion=0&suggestion=

I don't give one yota which kernelVersion the user runs. I quite intentionally want to send the "prettyOSVersion"
I don't want to change the "appCpuArch=" parameter to "buildCpuArchitecture="
etc.

NAK.

/D