annoying warnings from Qt on the console

[Dirk Hohndel]

On Mon, Aug 18, 2014 at 09:37:05PM +0300, Lubomir I. Ivanov wrote:
> it's caused by marble.
> 
> i very much suspect that it's a stupid lack of empty string checks in
> their code base in multiple locations.
> we've already seen examples of the code quality in there, yet any good
> alternatives are absent.
> 
> something in the lines of:
> QString emptyString;
> QFile f(emptyString);
> f.open(QFile::ReadOnly);
> 
> trying to copy all files from marblesource/marbledata to
> susbsurface/marbledata doesn't solve it for me.
> the actual warning cannot be removed either since it always triggers
> from QFSFileEngine::open(), and that's fine because it targets not
> users but developers to improve their code (e.g. fopen(NULL...) a sane
> thing?).

As I said, I think having this warning in a release build is silly.

But I made progress. I hacked my Marble a little more and have now zero
warnings. Part of this was done by adding a few more of the PNGs that they
are looking for (and not dealing with their absences at all), part of it
was commenting out some code that initializes data that then (in my
version) never gets used.

> the Windows user will not see it anyway as we don't have the console
> for the regular release build.
> to what exact areas of marble it's related and why it only possibly
> happens on Windows(?) - no idea.

I was able to reproduce it on Linux as I stated in my email.
But my next Marble builds for Windows should have this any more, either
(assuming I remember to bring the patch over to that).

/D