CCR code: Splitting a C code file

Willem Ferguson willemferguson at zoology.up.ac.za
Sat Aug 23 12:39:07 PDT 2014


On 23/08/2014 16:44, Dirk Hohndel wrote:
>
> On August 23, 2014 7:29:47 AM Willem Ferguson 
> <willemferguson at zoology.up.ac.za> wrote:
>
>>
>> The function name is not resolved. I suspect I do not understand the
>> interaction between qmake and make. Is this correct?
>
> Is the function marked as "static" by any chance?
>
> /D
>
You are clairvoyant. Yes, you are absolutely correct and I should have 
seen the problem.

static inline int pressure_time(struct dive*, struct divecomputer*, 
struct plot_data*, struct plot_data*);

Two issues:

1) What would be the consequences if one changed the definition to int 
pressure_time?

The function is only called once by profile.c.

2) If I had a free choice, to avoid confusion, I would rename it to 
calc_pressure_time because, within profile.c,  there are variables with 
the name pressure_time.

Does this make sense at all?

Kind regards,
willem



More information about the subsurface mailing list